Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops mentors seeing debug messages #6598

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jun 30, 2024

About the pull request

As title

Explain why it's good for the game

Shouldn't be sending debug logs to mentors.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
admin: Mentors no longer receive debug logs as a result of being in GLOB.admins
/:cl:

@github-actions github-actions bot added the Admin Make things harder for admins label Jun 30, 2024
@Git-Nivrak
Copy link
Contributor

Consider instead of adding snowflake checks everywhere to split GLOB.admins into GLOB.mentors and GLOB.staff

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nivrak's correct that it'd be preferable but a lot of stuff depends on mentors having an admin_holder and a lot of stuff requires admin_holders to be in GLOB.admins. alas, out of scope

@harryob harryob added this pull request to the merge queue Jul 6, 2024
Merged via the queue into cmss13-devs:master with commit 3f66f29 Jul 6, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants